From: Matthieu Moy Date: Thu, 10 Sep 2015 16:57:14 GMT Subject: Re: [PATCH v17 00/14] port tag.c to use ref-filter APIs Message-ID: In-Reply-To: <1441900110-4015-1-git-send-email-Karthik.188@gmail.com> Karthik Nayak writes: > This is part of the series of unifying the code used by > "git tag -l, git branch -l, git for-each-ref". > > The previous version can be found here (version 16): > article.gmane.org/gmane.comp.version-control.git/277394 > > Changes in this version: > * The arguments of the %(align) atom are interchangeable. > * Small grammatical changes. > * Small changes in the tests to reflect changes in the align > atom code. Clearly, we're almost there. I did a few minor remarks. I suggest (admitedly, Eric suggested of-list to suggest ;-) ) that you reply to them by re-sending only individual patches that changed (replying to the original patch) so that we can check the new patches individually. I think we can do the finishing touches for each patch in a subthread of this patch. -- Matthieu Moy http://www-verimag.imag.fr/~moy/