From: Matthieu Moy Date: Thu, 02 May 2013 15:03:25 GMT Subject: Re: [PATCH v4 2/3] Show items of interactive git-clean in columns Message-ID: In-Reply-To: <3b80db3d2e8f31b1d9373406cce3cbdee2094a29.1367500374.git.worldhello.net@gmail.com> Jiang Xin writes: > Signed-off-by: Jiang Xin This lacks a proper commit message (why is this a good thing?), and documentation (you introduce column.clean) but the code sounds good (that's a very quick look from me, not a "review" sorry). -- Matthieu Moy http://www-verimag.imag.fr/~moy/