From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Fri, 27 May 2016 14:52:49 GMT
Subject: Re: [PATCH v4] upload-pack.c: use of parse-options API
Message-ID: <vpqpos7o8n2.fsf@anie.imag.fr>
In-Reply-To: <20160527141628.1677-1-Antoine.Queru@ensimag.grenoble-inp.fr>

> Subject: [PATCH v4] upload-pack.c: use of parse-options API

I'd drop the "of" and say just "use parse-options API"

Antoine Queru <Antoine.Queru@ensimag.grenoble-inp.fr> writes:

> Description for --stateless-rpc and --advertise-refs come from
> the commit 42526b4 (Add stateless RPC options to upload-pack,

Nit: s/the//

> +--advertise-refs::
> +	When --advertise-refs is passed as a command line parameter only
> +    	the initial ref advertisement is output, and the program exits
> +    	immediately.  This fits with the HTTP GET request model, where
> +    	no request content is received but a response must be produced.

Another nit: mix space/tab in indentation (renders badly on some
configurations).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/