From: Matthieu Moy Date: Wed, 14 Mar 2012 13:00:38 GMT Subject: Re: [PATCH] push: Provide situational hints for non-fast-forward errors Message-ID: In-Reply-To: <20120314121434.GB28595@in.waw.pl> Zbigniew Jędrzejewski-Szmek writes: > I think that having three different config keys for the three > different advices makes sense, because the advices will be displayed > at different times. I don't think it really makes sense to be such fine-grained. We already have 6 different advices, so an advance user who do not want them need to set these 6 variables. I think we want to keep this number relatively low. The advice messages do not point explicitely to the way to disable them, so users who know how to set advice.* are users who know a little about configuration files, and who read the docs. Instead of having too fine-grained configuration variables, we can have a better doc, explaining shortly the 3 possible cases under advice.nonfastforward in config.txt. The user who disable the advice can read the doc (I usually think that "users don't read documentation" is a better assumption, but since the user knows about the name of the variable, it is OK here). Also, if I read correctly the patch, the old variable is left in the doc and in advice.{c,h}, but is no longer used. This means old-timers who have set it will see the message poping-up again after they upgrade, which I think is inconveinient for them. -- Matthieu Moy http://www-verimag.imag.fr/~moy/