From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Wed, 03 Jul 2013 09:18:49 GMT
Subject: Re: [PATCH v7 4/7] git-remote-mediawiki: Update tests to run with the new bin-wrapper
Message-ID: <vpqobakrog6.fsf@anie.imag.fr>
In-Reply-To: <1372804789-12732-5-git-send-email-benoit.person@ensimag.fr>

benoit.person@ensimag.fr writes:

> --- a/contrib/mw-to-git/t/test-gitmw-lib.sh
> +++ b/contrib/mw-to-git/t/test-gitmw-lib.sh
> @@ -62,12 +62,8 @@ test_check_precond () {
>  		test_done
>  	fi
>  
> -	if [ ! -f "$GIT_BUILD_DIR"/git-remote-mediawiki ];
> -	then
> -		echo "No remote mediawiki for git found. Copying it in git"
> -		echo "cp $GIT_BUILD_DIR/contrib/mw-to-git/git-remote-mediawiki $GIT_BUILD_DIR/"
> -		ln -s "$GIT_BUILD_DIR"/contrib/mw-to-git/git-remote-mediawiki "$GIT_BUILD_DIR"
> -	fi
> +	GIT_EXEC_PATH=$(cd "$(dirname "$0")" && cd "../.." && pwd)
> +	PATH="$GIT_EXEC_PATH"'/bin-wrapper:'"$PATH"
>  
>  	if [ ! -d "$WIKI_DIR_INST/$WIKI_DIR_NAME" ];
>  	then

Cool!

I like the way adding a new feature has positive side effects on the
rest of the code.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/