From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Tue, 29 Jul 2014 07:57:45 GMT
Subject: Re: [PATCH] use a hashmap to make remotes faster
Message-ID: <vpqoaw8ha12.fsf@anie.imag.fr>
In-Reply-To: <305063.319715799-sendEmail@debian>

"patrick.reynolds@github.com" <patrick.reynolds@github.com> writes:
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

It seems you mixed your name and email address in your config file. I
guess your name is "Patrick Reynolds", not
"patrick.reynolds@github.com".

> Remotes are stored as an array, so looking one up or adding one without
> duplication is an O(n) operation.  Reading an entire config file full of
> remotes is O(n^2) in the number of remotes.  For a repository with tens of
> thousands of remotes, the running time can hit multiple minutes.

Just being curious: in which senario do you have tens of thousands of
remotes?

(not an objection, it's a good thing anyway)

> +static inline void init_remotes_hash()

static inline void init_remotes_hash(void)

Not a detailed review, but the patch sounds good other than that.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/