From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Thu, 31 Jul 2014 11:22:29 GMT
Subject: Re: [PATCH v5 3/7] change `git_config()` return value to void
Message-ID: <vpqoaw5epsa.fsf@anie.imag.fr>
In-Reply-To: <1406799857-28048-4-git-send-email-tanayabh@gmail.com>

Tanay Abhra <tanayabh@gmail.com> writes:

> Signed-off-by: Tanay Abhra <tanayabh@gmail.com>

I think I deserve a bit of credit here ;-).

>  {
> -	return git_config_with_options(fn, data, NULL, 1);
> +	if (git_config_with_options(fn, data, NULL, 1) < 0)
> +		/*
> +		 * git_config_with_options() normally returns only
> +		 * positive values, as most errors are fatal, and
> +		 * non-fatal potential errors are guarded by "if"
> +		 * statements that are entered only when no error is
> +		 * possible.
> +		 *
> +		 * If we ever encounter a non-fatal error, it means
> +		 * something went really wrong and we should stop
> +		 * immediately.
> +		 */
> +		die("Unknown error occured while reading the configuration files");
>  }

My bad, but this should be die(_("..."));, so that the message can be
translated. Not really serious since it's not really meant to be seen by
the user, though.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/