From: Matthieu Moy Date: Mon, 01 Jun 2015 06:38:57 GMT Subject: Re: [WIP/PATCH v4 6/8] for-each-ref: rename some functions and make them public Message-ID: In-Reply-To: Christian Couder writes: > sort_refs() -> ref_array_sort() > struct ref_sort -> struct ref_sort_criteria > default_sort() -> ref_default_sort_criteria() > opt_parse_sort() -> opt_parse_ref_sort_criteria() BTW, having such summary in the log message would help review: we could think and discuss the naming by looking just at the summary, and then check that you did it correctly (easy). -- Matthieu Moy http://www-verimag.imag.fr/~moy/