From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Tue, 12 Jun 2012 09:25:46 GMT
Subject: Re: [PATCHv2 2/2] git-remote-mediawiki: refactoring get_mw_pages function
Message-ID: <vpqmx48x4o5.fsf@bauges.imag.fr>
In-Reply-To: <CA+hdvHhn1G=T=KjNvgXa-2M6oh2znbHmfZFZYPdqKhtybh_MoQ@mail.gmail.com>

Simon Perrat <simon.perrat@gmail.com> writes:

> 2012/6/11 Pavel Volek <Pavel.Volek@ensimag.imag.fr>:
>
>> +sub get_mw_all_pages {
>> +       my $pages = shift;
>> +       # No user-provided list, get the list of pages from the API.
>> +       my $mw_pages = $mediawiki->list({
>> +               action => 'query',
>> +               list => 'allpages',
>> +               aplimit => 500
>> +       });
>
> Indentation should be 8 columns wide.

More precisely, indentation in Git is done with tabs, and should display
well with 1 tab == 8 characters.

It is actually the case in Pavel's patch. When seen as patches, the
first column is used for + and -, so the first tab is rendered as only 7
characters, but that's normal.

Or did I miss something?

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/