From: Matthieu Moy Date: Tue, 03 Jun 2014 15:20:39 GMT Subject: Re: [PATCH v2] string-list: Add a value to string_list initializer lists Message-ID: In-Reply-To: <1401786798-3729-1-git-send-email-tanayabh@gmail.com> Tanay Abhra writes: > diff --git a/Documentation/technical/api-string-list.txt b/Documentation/technical/api-string-list.txt > index 20be348..f1add51 100644 > --- a/Documentation/technical/api-string-list.txt > +++ b/Documentation/technical/api-string-list.txt > @@ -200,3 +200,5 @@ Represents the list itself. > You should not tamper with it. > . Setting the `strdup_strings` member to 1 will strdup() the strings > before adding them, see above. > +. The `compare_strings_fn` member is used to specify a custom compare > + function, otherwise `strcmp()` is used as the default function. Is this change intentional? It seems good, but not really related to the change described in the commit message. In any case, this remark should not block patch inclusion, it's trivial enough. -- Matthieu Moy http://www-verimag.imag.fr/~moy/