From: Matthieu Moy Date: Wed, 07 Oct 2015 17:58:03 GMT Subject: Re: [PATCH 8/9] branch: use ref-filter printing APIs Message-ID: In-Reply-To: Karthik Nayak writes: > On Wed, Oct 7, 2015 at 12:33 AM, Matthieu Moy > wrote: > >> To go a bit further, you can pre-build a string or strbuf aligned_short >> with value like "%%(align:20,left)%%(refname:short)%%(end)" and use it >> where needed (it's not a constant because you have to introduce maxwidth >> into the string, so it's not a candidate for #define). >> > > Again, the remote has a remote prefix here, so we can't really factor > it out much. Ah, OK, there's a %s containing the remote prefix in "remote" that is not there in "local", and in the last version you sent it's already factored for verbose > 1 and verbose == 1. Indeed, there's nothing more to gain here. -- Matthieu Moy http://www-verimag.imag.fr/~moy/