From: Matthieu Moy <matthieu.moy@imag.fr>
Date: Sat, 24 Nov 2007 18:23:10 GMT
Subject: Re: [RFC/PATCH] git-help: add new options -w (for web) and -i (for info)
Message-ID: <vpqlk8nv6y9.fsf@bauges.imag.fr>
In-Reply-To: <47482116.70600@op5.se>

Andreas Ericsson <ae@op5.se> writes:

> Alex Riesen wrote:
>> Christian Couder, Sat, Nov 24, 2007 05:16:50 +0100:
>>> +valid_tool() {
>>> +	case "$1" in
>>> +		firefox | iceweasel | konqueror | w3m)
>>> +			;; # happy
>>
>> lynx, links and dillo?
>>
>
> Why bother validating it at all? I might be using a script to
> add some formatting and then pass it through the browser of my
> choice. A friend of mine who's visually impaired does just that
> to strip some CSS tags which can make docs quite unreadable for
> him.

In any case, make sure it's consistant with git instaweb, which also
runs a web browser (firefox by default, overridable with --browser or
instaweb.browser).

-- 
Matthieu