From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Sun, 12 May 2013 17:09:39 GMT
Subject: Re: [PATCH v7 02/10] Show items of interactive git-clean in columns
Message-ID: <vpqli7ki0q4.fsf@grenoble-inp.fr>
In-Reply-To: <6a7931a0bb14f8c71479e16175812bedb6b826cb.1368011946.git.worldhello.net@gmail.com>

Jiang Xin <worldhello.net@gmail.com> writes:

> +column.clean::
> +	Specify whether to output cleaning files in `git clean -i` in columns.
> +	See `column.ui` for details.
> +


> +static void pretty_print_dels()

Ah, OK. That's the helper function I was expecting in 01/10. The patches
would be easier to review if the helper was introduced in 01/10 and
then modified here to add column display, but the result is OK.

> +	/*
> +	 * always enable column display, we only consult column.*
> +	 * about layout strategy and stuff
> +	 */

Isn't this conflicting with the documentation above?

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/