From: Matthieu Moy Date: Wed, 13 May 2015 09:38:47 GMT Subject: Re: [PATCH 2/2] pull: handle --log= Message-ID: In-Reply-To: <1431508661-21729-3-git-send-email-pyokagan@gmail.com> Paul Tan writes: > - --log|--no-log) > - log_arg=$1 ;; > + --log|--log=*|--no-log) > + log_arg="$1" ;; I think you actually don't need the double quotes here (var=$value works even if $value has spaces IIRC), but they don't harm and I prefer having them. -- Matthieu Moy http://www-verimag.imag.fr/~moy/