From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Wed, 10 Jun 2015 15:55:48 GMT
Subject: Re: [PATCH/RFCv5 2/3] git rebase -i: warn about removed commits
Message-ID: <vpqlhfr4kxn.fsf@anie.imag.fr>
In-Reply-To: <1634653813.334490.1433951239962.JavaMail.zimbra@ensimag.grenoble-inp.fr>

Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr> writes:

> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>> > +                        warn_file "$todo".miss
>> 
>> I would find it more elegant with less intermediate files, like
>> 
>> git rev-list $opt <"$todo".miss | while read -r line
>> do
>>         warn " - $line"
>> done
>
> I am not really sure since I also use warn_file to display the bad
> commands and SHA-1 in 3/3.

I noticed this later indeed. But had the function been eg. warn_pipe,
you could have written

git rev-list $opt <"$todo".miss | warn_pipe

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/