From: Matthieu Moy Date: Sun, 11 Oct 2015 19:32:23 GMT Subject: Re: [PATCH v2 00/10] port branch.c to use ref-filter's printing options Message-ID: In-Reply-To: Karthik Nayak writes: > On Sun, Oct 11, 2015 at 9:51 PM, Matthieu Moy > wrote: >> Karthik Nayak writes: >> >>> Also does it make sense to integrate these changes here? Or would you like to >>> have another series on this? >> >> To me, the important in this series is to avoid introducing duplicated >> and inconsistent code, because it would make further refactoring harder. >> > > Would you suggest duplicating whats done with %(align) here? I think introducing a function to split according to commas and remove commas would make sense, but I won't insist on that. Mimicking what's done with %(align) is acceptable to me: we'll have several instances of the same pattern, not ideal but easy enough to refactor later. Especially if you actually plan to work on that :-). -- Matthieu Moy http://www-verimag.imag.fr/~moy/