From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Wed, 18 Aug 2010 13:47:55 GMT
Subject: Re: [RFC/PATCH] Add test case for dealing with a tracked file in an ignored directory
Message-ID: <vpqk4noc9ro.fsf@bauges.imag.fr>
In-Reply-To: <AANLkTi=UJmXx0-fV6OqDTOzuTdQQWioUb=3vrVx01qi6@mail.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

> On Wed, Aug 18, 2010 at 09:29, Greg Brockman <gdb@mit.edu> wrote:
>
>> +cat >expect <<EOF
>> +The following paths are ignored by one of your .gitignore files:
>> +ignored-dir
>> +Use -f if you really want to add them.
>> +fatal: no files added
>> +EOF
>
> Please make this a test, per this bit in t/README:
>
>  - Put all code inside test_expect_success and other assertions.
>
>    Even code that isn't a test per se, but merely some setup code
>    should be inside a test assertion.

Not sure what is the gain by doing so, and the vast majority of tests
already there use the style of Greg's patch ...

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/