From: Matthieu Moy Date: Wed, 11 Apr 2012 17:59:23 GMT Subject: Re: [PATCH 1/5] t1507: add additional tests for @{upstream} Message-ID: In-Reply-To: <7vfwcakvfw.fsf@alter.siamese.dyndns.org> Junio C Hamano writes: > We may want to update the error message for "@{u}" when the current one is > not tracked, instead of saying ''. Perhaps > > error: No upstream branch found for the current branch. > > or something? > > Likewise for the detached HEAD case. This is indeed the point of the patch serie, and I like how it first shows how bad the error messages can be, and then illustrate the fix with patch hunks in the newly added testcases in further patches. But the commit message for this patch could probably be improved: we usually do not give a list of _what_ is done, since the code already says that, but we insist on _why_ it is done. -- Matthieu Moy http://www-verimag.imag.fr/~moy/