From: Matthieu Moy Date: Fri, 26 Apr 2013 13:23:55 GMT Subject: Re: [PATCHv2 7/7] git grep: honor textconv by default Message-ID: In-Reply-To: <517A6C0C.1020506@drmicha.warpmail.net> Michael J Gruber writes: > BTW, textconv does not have to be slow - just use textconv-cache. Right, thanks for reminding me about this, I had forgotten its existance ;-). > I'm still looking for a way to at least treat "git grep" and "git show > blob" the same way. I agree they should be treated similarly. > - Implement the --textconv option but leave the default as is. I did > that for "git grep" already (just drop 7/7) That seems sensible. > but it seems to be cumbersome for "git show blob". I have to recheck. It should be possible to have a tri-state for the --[no-]textconv option: unset, set to true or set to false. But the code sharing between log, show and diff might make that non-trivial. -- Matthieu Moy http://www-verimag.imag.fr/~moy/