From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Tue, 01 Sep 2015 13:11:42 GMT
Subject: Re: [PATCH v14 04/13] ref-filter: implement an `align` atom
Message-ID: <vpqk2sa1dyp.fsf@anie.imag.fr>
In-Reply-To: <CAOLa=ZQV63ZETPswEPYjSMrXcZAK+W-Jek+Psq7wtmSsQHtb3g@mail.gmail.com>

Karthik Nayak <karthik.188@gmail.com> writes:

> Like this:
>
>  else if (skip_prefix(name, "align", &valp)) {
>             struct align *align = &v->u.align;
>             struct strbuf **s;
>
>             if (valp[0] != ':')
>                 die(_("format: usage %%(align:<width>,<position>)"));
>             else
>                 valp++;
>             ......
>             ........
> }

Checking the string's correctness as you read it seems good to me, yes.

But as you say, you should make this a bit more generic, for example by
putting your "if/else" in a helper function, that other atoms could use.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/