From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Fri, 25 Sep 2015 05:55:19 GMT
Subject: Re: [PATCH v6b 5/8] branch: drop non-commit error reporting
Message-ID: <vpqk2rfm4ag.fsf@grenoble-inp.fr>
In-Reply-To: <1443118148-3470-1-git-send-email-Karthik.188@gmail.com>

Karthik Nayak <karthik.188@gmail.com> writes:

> Remove the error "branch '%s' does not point at a commit" in
> apppend_ref() which reports branch refs which do not point to
> commits. Also remove the error "some refs could not be read" in
> print_ref_list() which is triggered as a consequence of the first
> error.
>
> This seems to be the wrong codepath whose purpose is not to diagnose
> and report a repository corruption. If we care about such a repository
> corruption, we should report it from fsck instead.

(We actually already report it from fsck indeed)

> This also helps in a smooth port of branch.c to use ref-filter APIs
> over the following patches. On the other hand, ref-filter ignores refs
> which do not point at commits silently.

Seems much better. Thanks,

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/