From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Sat, 02 Jun 2012 10:47:54 GMT
Subject: Re: [PATCH 2/3] Test environment of git-remote-mw
Message-ID: <vpqipfa9ehx.fsf@bauges.imag.fr>
In-Reply-To: <4FC8D501.20207@ensimag.imag.fr>

"Simon.Cathebras" <Simon.Cathebras@ensimag.imag.fr> writes:

>>> +wiki_getpage () {
>>> +	../test-gitmw.pl get_page -p "$1" "$2"
>>> +}
>> Any reason why test-gitmw.pl and wiki_getpage have this slightly
>> different API? The perl version has a "-p" flag, and the shell command
>> has only positionnal arguments.
> The "-p" flag exists to specify if we have to use the admin login on
> wiki to do the command.

(then, maybe --admin would be a better name?)

> For instance, here we fetch a page from the wiki with Admin privilege.
> Others arguments remains the same.

What I don't understand is why you need the flexibility to choose
between admin and non-admin on the Perl side, and you don't need in on
the shell side.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/