From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Thu, 04 Apr 2013 17:03:58 GMT
Subject: Re: [PATCH 1/2] diffcore-pickaxe: respect --no-textconv
Message-ID: <vpqip42qlc1.fsf@grenoble-inp.fr>
In-Reply-To: <20130404160359.GA25232@ruderich.org>

Simon Ruderich <simon@ruderich.org> writes:

> This patch should fix it.

It does.

> --- a/diffcore-pickaxe.c
> +++ b/diffcore-pickaxe.c
> @@ -78,7 +78,6 @@ static void fill_one(struct diff_filespec *one,
>  		     mmfile_t *mf, struct userdiff_driver **textconv)
>  {
>  	if (DIFF_FILE_VALID(one)) {
> -		*textconv = get_textconv(one);
>  		mf->size = fill_textconv(*textconv, one, &mf->ptr);
>  	} else {
>  		memset(mf, 0, sizeof(*mf));

I don't understand why this is needed (not rethorical, I just didn't
investigate), but the rest of the code looks straightforward and
correct.

Thanks,

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/