From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Tue, 28 Jul 2015 13:38:34 GMT
Subject: Re: [RFC/PATCH 03/11] ref-filter: add option to filter only branches
Message-ID: <vpqio94wgf9.fsf@anie.imag.fr>
In-Reply-To: <1438066594-5620-3-git-send-email-Karthik.188@gmail.com>

Karthik Nayak <karthik.188@gmail.com> writes:

> +static int filter_branch_kind(struct ref_filter *filter, const char *refname)
> +{
> +	int kind, i;
> +
> +	static struct {
> +		int kind;
> +		const char *prefix;
> +	} ref_kind[] = {
> +		{ REF_LOCAL_BRANCH, "refs/heads/" },
> +		{ REF_REMOTE_BRANCH, "refs/remotes/" },
> +	};

Nit: I would swap the order of fields, to make it a bit clearer that
this is a kind of dictionary key -> value (I think it's more common to
write it in this order than value <- key).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/