From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Tue, 28 Jul 2015 08:42:22 GMT
Subject: Re: [RFC/PATCH 01/11] ref-filter: add "%(objectname:size=X)" option
Message-ID: <vpqio941xn5.fsf@anie.imag.fr>
In-Reply-To: <1438066594-5620-1-git-send-email-Karthik.188@gmail.com>

Karthik Nayak <karthik.188@gmail.com> writes:

> +	if (skip_prefix(name, "objectname:size=", &p)) {
> +		unsigned int size = atoi(p);

You have the same problem as for tag.c: don't use atoi, and make
accurate error checking (absence of value, negative value, non-integer
value).

If you have other higher-priorities task, leave a temporary comment 
/* FIXME: ... */ or /* TODO: ... */ and make sure you have no such
comment when you drop the "RFC" in the subject of your emails.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/