From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Thu, 15 Oct 2015 16:42:23 GMT
Subject: Re: [PATCH 1/3] strbuf: make stripspace() part of strbuf
Message-ID: <vpqio6813tc.fsf@grenoble-inp.fr>
In-Reply-To: <1444911524-14504-2-git-send-email-tklauser@distanz.ch>

Tobias Klauser <tklauser@distanz.ch> writes:

> Also switch all current users of stripspace() to the new function name
> and  keep a temporary wrapper inline function for topic branches still
> using stripspace().

Since you have this temporary wrapper, it would have made sense to split
the patch into 1) move and rename the function, and 2) change the
callsites to strbuf_stripspace. This way 2) would be absolutely trivial
to review.

OTOH, this patch is already easy to review, so you may consider it's OK
like this.

Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/