From: Matthieu Moy Date: Thu, 07 Apr 2016 17:36:07 GMT Subject: Re: [PATCH 3/4] builtin/am: read mailinfo from file Message-ID: In-Reply-To: <1460042563-32741-4-git-send-email-mst@redhat.com> "Michael S. Tsirkin" writes: > - strbuf_addbuf(&msg, &mi.log_message); > + > + if (strbuf_read_file(&log_msg, am_path(state, "msg"), 0) < 0) { > + die_errno(_("could not read '%s'"), am_path(state, "msg")); > + } Style: we omit the braces where not needed. -- Matthieu Moy http://www-verimag.imag.fr/~moy/