From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Thu, 20 Jun 2013 09:45:04 GMT
Subject: Re: [PATCH v4 5/5] git-remote-mediawiki: Add preview subcommand into git mw.
Message-ID: <vpqhagtazfj.fsf@anie.imag.fr>
In-Reply-To: <1371712593-6210-6-git-send-email-benoit.person@ensimag.fr>

benoit.person@ensimag.fr writes:

> +	for (@{ $html_tree->extract_links() }) {
> +		my ($link, $element, $attr) = @{ $_ };
> +		my $url = url($link)->canonical;
> +		$element->attr($attr, URI->new_abs($url, $remote_url));

Actually, this breaks some relative links, like table of content links,
because you consider them relative to URLs like http://example.com/wiki/
but not http://example.com/wiki/index.php/My_Page.

Ideally, links pointing to stg like "#anchor" should not be modified.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/