From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Wed, 26 Mar 2014 12:19:54 GMT
Subject: Re: [PATCH v2 001/142] check-builtins.sh: use the $( ... ) construct for command substitution
Message-ID: <vpqha6l5ez9.fsf@anie.imag.fr>
In-Reply-To: <8738i6uihf.fsf@fencepost.gnu.org>

David Kastrup <dak@gnu.org> writes:

> Junio C Hamano <gitster@pobox.com> writes:
>
>> Elia Pinto <gitter.spiros@gmail.com> writes:
>>
>>> The Git CodingGuidelines prefer the $( ... ) construct for command
>>> substitution instead of using the back-quotes, or grave accents (`..`).
>>>
>>> The backquoted form is the historical method for command substitution,
>>> and is supported by POSIX. However, all but the simplest uses become
>>> complicated quickly. In particular, embedded command substitutions
>>> and/or the use of double quotes require careful escaping with the backslash
>>> character. Because of this the POSIX shell adopted the $(…) feature from
>>> the Korn shell.
>>>
>>> The patch was generated by the simple script
>>>
>>> for _f in $(find . -name "*.sh")
>>> do
>>>   sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
>>> done
>>
>> "and then carefully proofread" is sorely needed here.
>
> It would already help to skip comment lines.

Actually no: most comments including `...` are code examples that we
want to fix too, except 3 instances (see my other message).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/