From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Wed, 29 Jul 2015 21:21:14 GMT
Subject: Re: [RFC/PATCH 04/11] ref-filter: add 'ifexists' atom
Message-ID: <vpqh9omek39.fsf@anie.imag.fr>
In-Reply-To: <xmqqtwsm94j1.fsf@gitster.dls.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

> Junio C Hamano <gitster@pobox.com> writes:
>
>>> Couldn't think of a better replacer, any suggestions would be welcome :)
>>
>> See below.
>> ...
>> One way to do all of the above is ...
>
> Note that is just "one way", not the only or not necessarily the
> best.  It certainly is not the easiest, I think.
>
>     %(if:atom)...%(endif)
>
> might be easier to implement.

And I find it easier to read or write too. Nested parenthesis in a
format string make them really tricky. That removes the need for
escaping since the content of the if/endif is a format string like the
others, it can use the same escaping rules (IIRC, %% to escape a %).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/