From: Matthieu Moy Date: Thu, 05 Aug 2010 16:47:21 GMT Subject: Re: [PATCH] rebase -i: add exec command to launch a shell command Message-ID: In-Reply-To: Ævar Arnfjörð Bjarmason writes: >> +in `$SHELL`, or the default shell if `$SHELL` is not set), so you can >> +use usual shell commands like "cd". The command is run from the > > I think that needs a definite article: ".. use the usual ..". I don't think so, especially with a plural "commands" after. Googlefight agrees with me ("use the usual commands" => 350 results, "use usual commands" => 4900), but that's not a proof. Perhaps a native speaker could help? > As I pointed out in a previous comment to the series this sort of > debug code should either be converted to use "test" or we should > incorporate it into test-lib.sh and use it everywhere. > > I somewhat like the latter. It's sometimes hard to see what's going > wrong with our tests. It'd also translate to TAP subtests. I'll do both: use test -f in a first patch, and propose alternative in the second. New patch serie follows. I don't know TAP and TAP subtests, but if the functions exist, other patches can be added on top to improve them. -- Matthieu Moy http://www-verimag.imag.fr/~moy/