From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Sun, 12 May 2013 17:15:11 GMT
Subject: Re: [PATCH v7 03/10] Add colors to interactive git-clean
Message-ID: <vpqfvxsi0gw.fsf@grenoble-inp.fr>
In-Reply-To: <d7302adabb4269dd94698090fb20c739f723f00a.1368011946.git.worldhello.net@gmail.com>

Jiang Xin <worldhello.net@gmail.com> writes:

>  * color.interactive.<slot>: Use customized color for interactive
>    git-clean output (like git add --interactive). <slot> may be
>    prompt, header, help or error.

This should go to the documentation (a short summary is welcome in the
commit messages in addition, but users won't read this...)

> +	if (!prefixcmp(var, "color.interactive.")) {
> +		int slot = parse_clean_color_slot(var, 18);

For readability and maintainability: please use
strlen("color.interactive."), not 18.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/