From: Matthieu Moy Date: Wed, 19 Mar 2014 15:21:18 GMT Subject: Re: [PATCH 1/3] diff-no-index.c read_directory() use is_dot_or_dotdot(). Message-ID: In-Reply-To: <1395242180-4559-1-git-send-email-mandrei.dinu@gmail.com> > Subject: Re: [PATCH 1/3] ^^^ I guess you meant PATCH v3. 1/3 means that this is the first patch out of 3. Andrei Dinu writes: > Implement read_directory() to use is_dot_or_dotdot() function from dir.h > instead of strcmp(). > > Rename read_directory() in read_directory_path() to avoid conflicting with > read_directory() from dir.h. Ideally, these should be two distinct patches. One to rename read_directory (no real change), and the next one to use is_dot_or_dotdot. You may want to take this as an exercice to learn how to split a patch, but I won't insist on that. Other than that, the patch looks good. -- Matthieu Moy http://www-verimag.imag.fr/~moy/