From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Tue, 20 May 2014 14:07:47 GMT
Subject: Re: [PATCH 10/19] git-submodule.sh: convert test -a/-o to && and ||
Message-ID: <vpqegzo4k7g.fsf@anie.imag.fr>
In-Reply-To: <1400593832-6510-11-git-send-email-gitter.spiros@gmail.com>

Elia Pinto <gitter.spiros@gmail.com> writes:

> -			test $status = D -o $status = T && echo "$sm_path" && continue
> +			{
> +			test "$status" = D ||
> +			test "$status" = T
> +			} &&
> +			echo "$sm_path"
> +			&& continue

We usually write the && at the end of the line, hence that would be

echo "$sm_path" &&
continue

(shouldn't block the patch, but you may change if you need to resend)

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/