From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Sat, 02 Jul 2011 13:54:06 GMT
Subject: Re: [PATCH] git svn : hook before 'git svn dcommit'
Message-ID: <vpqboxcu6td.fsf@bauges.imag.fr>
In-Reply-To: <4E0F1383.8080804@gmail.com>

Frédéric Heitzmann <frederic.heitzmann@gmail.com> writes:

> The 'pre-svn-dcommit' hook si called before 'git svn dcommit', which aborts
> if return value is not zero.
> ---
>  git-svn.perl |   19 +++++++++++++++++++

What about documentation?

> +       if ($? == -1) {
> +               print "[pre_svn_dcommit_hook] failed to execute $hook:
> $!\n";

whitespace damage (extra newline)

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/