From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Sun, 07 Apr 2013 16:20:57 GMT
Subject: Re: [PATCH v3 4/4] format-patch: add format.cover-letter configuration
Message-ID: <vpqbo9qfh1y.fsf@grenoble-inp.fr>
In-Reply-To: <CAMP44s2TvC9Ek51GyhPqtv7b-w8u8kr=tQsmdWEVGOycb6MEqA@mail.gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

> On Sun, Apr 7, 2013 at 9:50 AM, Matthieu Moy
> <Matthieu.Moy@grenoble-inp.fr> wrote:
>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>
>>> So, I'm a user that does 'git format-patch --cover-letter=auto origin'
>>> so I don't have the format.coverletter=auto configuration. Why? Why am
>>> I not setting that configuration, and why am I running
>>> --cover-letter=auto?
>>
>> The command may well be ran from a script or alias.
>
> Wouldn't this work for both cases?
>
> % git -c format.coverletter=auto format-patch

Then, what's the point in having a --cover-letter option?

"git -c" is a good last-chance solution, but when we provide the same
feature as a command-line option and as a configuration option, I can
see no reason to add subtle difference between them.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/