From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Fri, 05 Jul 2013 11:31:10 GMT
Subject: Re: [PATCH] send-email: squelch warning from Net::SMTP::SSL
Message-ID: <vpqbo6hw8e9.fsf@anie.imag.fr>
In-Reply-To: <CALkWK0nWvmuxfZJF_Mk2MmJNxz4+=46m_pBtzjSZprLxABhNeA@mail.gmail.com>

Ramkumar Ramachandra <artagnon@gmail.com> writes:

> John Keeping wrote:
>> I don't think this is really "fix", it's more plastering over the
>> problem.
>
> It defaulted to SSL_VERIFY_NONE before Net::SMTP::SSL was updated, and
> the behavior hasn't changed now.  The new version simply asks us to be
> explicit about SSL_VERIFY_NONE, so we are aware about it.

"We" as "the Git developers", yes. But your change makes sure users are
_not_ aware about it. There's a long history of software ignoring SSL
certificates by default, I don't think we should cast in stone that we
don't want SSL certificate verification.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/