From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Tue, 10 Mar 2015 13:26:38 GMT
Subject: Re: [PATCH v3 2/2] Added tests for reset -
Message-ID: <vpqa8zlx9td.fsf@anie.imag.fr>
In-Reply-To: <1425984728-27996-2-git-send-email-sudshekhar02@gmail.com>

Sudhanshu Shekhar <sudshekhar02@gmail.com> writes:

> +test_expect_success 'reset - while having file named - and no previous branch' '

I like having the expected behavior in the test name too. e.g. add
"fails" at the end of the sentence.

> +test_expect_success 'reset - in the presence of file named - with previous branch' '
> +	echo "Unstaged changes after reset:" >expect &&
> +	echo "M	-" >>expect &&
> +	echo "M	1" >>expect &&

Here and elsewhere: why not

	cat >expect <<-EOF
	Unstaged changes after reset:
	M -
	M 1

?

> +	rm -rf no_previous &&

That would be best done in a test_when_finished, so that the directory
is removed regardless of whether the test failed before this line or
not.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/