From: Matthieu Moy Date: Mon, 01 Jun 2015 15:12:05 GMT Subject: Re: [PATCH 2/2] send-email: allow multiple emails using --cc, --to and --bcc Message-ID: In-Reply-To: <1433168042-28269-2-git-send-email-remi.lespinet@ensimag.grenoble-inp.fr> Remi Lespinet writes: > Remove the limitation imposed by 79ee555b (Check and document the > options to prevent mistakes, 2006-06-21) which rejected every argument > with comma in --cc, --to and --bcc Missing "." at the end of sentence. > -The --bcc option must be repeated for each user you want on the bcc list. > +Addresses containing commas ("Foo, Bar" ) are not > +currently supported. > ++ > +This option may be specified multiple times Likewise (more instances in the patch). > +test_expect_success $PREREQ 'setup expected-list' ' > + git send-email \ > + --dry-run \ > + --from="Example " \ > + --to="to1@example.com" \ > + --to="to2@example.com" \ > + --to="to3@example.com" \ > + --cc="cc1@example.com" \ > + --cc="Cc 1 " \ > + --cc="Cc 2 " \ > + --bcc="bcc1@example.com" \ > + --bcc="bcc2@example.com" \ > + 0001-add-master.patch | replace_variable_fields \ Tab after |. Not really serious, but why not a space? > + >expected-list > +' > + > +test_expect_success $PREREQ 'use email list in --cc --to and --bcc' ' > + git send-email \ > + --dry-run \ > + --from="Example " \ > + --to="to1@example.com, to2@example.com" \ > + --to="to3@example.com" \ > + --cc="cc1@example.com, Cc 1 " \ > + --cc="Cc 2 " \ > + --bcc="bcc1@example.com, bcc2@example.com" \ > + 0001-add-master.patch | replace_variable_fields \ > + >actual-list && You may drop the space between TAB and >. I would group the tests: the 'setup' is only used to generate expected-list which is used only in the second test, so one is not useful without the other (we commonly have a 'setup ...' test which sets up something used by several other tests). -- Matthieu Moy http://www-verimag.imag.fr/~moy/