From: Matthieu Moy Date: Wed, 10 Jun 2015 16:08:15 GMT Subject: Re: [PATCH/RFCv5 3/3] git rebase -i: add static check for commands and SHA-1 Message-ID: In-Reply-To: <58099623.334723.1433951804504.JavaMail.zimbra@ensimag.grenoble-inp.fr> Remi Galan Alfonso writes: > It is mainly because here the SHA-1 is a long one (40 chars) OK, but then the minimum would be to add a comment saying that. Now, this makes me wonder why you are doing the check after the sha1 expansion and not before. Also, when running `git bisect --edit-todo`, I do get the short sha1. So, there's a piece of code doing what you want somewhere already. You may want to use it. -- Matthieu Moy http://www-verimag.imag.fr/~moy/