From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Thu, 08 Oct 2015 18:40:26 GMT
Subject: Re: [PATCH v2 07/10] ref-filter: make %(upstream:track) prints "[gone]" for invalid upstreams
Message-ID: <vpqa8rtnqzp.fsf@grenoble-inp.fr>
In-Reply-To: <1444295885-1657-8-git-send-email-Karthik.188@gmail.com>

Karthik Nayak <karthik.188@gmail.com> writes:

> --- a/ref-filter.c
> +++ b/ref-filter.c
> @@ -1118,8 +1118,10 @@ static void populate_value(struct ref_array_item *ref)
>  				char buf[40];
>  
>  				if (stat_tracking_info(branch, &num_ours,
> -						       &num_theirs, NULL))
> +						       &num_theirs, NULL)) {
> +					v->s = "[gone]";

My remark about translation still holds. The string was previously
translated in "branch" and you are removing this translation (well, not
here, but when 09/10 starts using this code).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/