From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Thu, 16 Feb 2017 16:41:32 GMT
Subject: Re: [PATCH 0/4 v4] WIP: allow "-" as a shorthand for "previous branch"
Message-ID: <vpqa89mnl4z.fsf@anie.imag.fr>
In-Reply-To: <1487258054-32292-1-git-send-email-kannan.siddharth12@gmail.com>

Siddharth Kannan <kannan.siddharth12@gmail.com> writes:

> This is as per our discussion[1]. The patches and commit messages are based on
> Junio's patches that were posted as a reply to
> <20170212184132.12375-1-gitster@pobox.com>.
>
> As per Matthieu's comments, I have updated the tests, but there is still one
> thing that is not working: log -@{yesterday} or log -@{2.days.ago}

Note that I did not request that these things work, just that they seem
to be relevant tests: IMHO it's OK to reject them, but for example we
don't want them to segfault. And having a test is a good hint that you
thought about what could happen and to document it.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/