From: Matthieu Moy Date: Sun, 06 Mar 2011 17:38:47 GMT Subject: Re: [Patch] Error message grammar Message-ID: In-Reply-To: <1299424888.4990.13.camel@SillyFace> A.J.Delaney@brighton.ac.uk writes: > Matthieu, > On Wed, 2011-03-02 at 23:03 +0100, Matthieu Moy wrote: >> Please, read >> http://repo.or.cz/w/git.git/blob_plain?f=Documentation/SubmittingPatches >> in particular the Signed-off-by part and the "don't attach patches" >> one. > Thanks for the pointer. Now, you should read the part about what goes before and after the --- in the message ;-). The body of the email (before ---) will become the commit message, you want it clean and self-contained. Discussions should go after the ---. If you don't follow this, our maintainer will have to fix it manually... > Based on master f70f736bcbb22cfe434eaf20089d9713b991ee31 This is not needed, and if you add it, put it after ---. > I certify conformance to Developer's Certificate of Origin 1.1. > > Signed-off-by: Aidan Delaney Just the Signed-off-by is sufficient. -- Matthieu Moy http://www-verimag.imag.fr/~moy/