From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Sun, 10 Jun 2012 18:12:13 GMT
Subject: Re: [PATCH_v1] add 'git credential' plumbing command
Message-ID: <vpq8vfvghoi.fsf@bauges.imag.fr>
In-Reply-To: <38899eac92a1ea5c17b98f5e7bd5d948@telesun.imag.fr>

roucherj <roucherj@telesun.imag.fr> writes:

> On Sat, 09 Jun 2012 21:52:36 +0200, konglu@minatec.inpg.fr wrote:
>>> +void cmd_credential (int argc, char **argv, const char *prefix){
>>> +	const char *op;
>>> +	struct credential c = CREDENTIAL_INIT;
>>> +	int i;
>>> +
>>> +	op = argv[1];
>>> +	if (!op)
>>> +		usage(usage_msg);
>>> +
>>> +	for (i = 2; i < argc; i++)
>>> +		string_list_append(&c.helpers, argv[i]);
>>> +
>>> +	if (credential_read(&c, stdin) < 0)
>>> +		die("unable to read credential from stdin");
>>> +
>>> +	if (!strcmp(op, "fill")) {
>>> +		credential_fill(&c);
>>> +		if (c.username)
>>> +			printf("username=%s\n", c.username);
>>> +		if (c.password)
>>> +			printf("password=%s\n", c.password);
>>> +	}
>>> +	else if (!strcmp(op, "approve")) {
>>> +		credential_approve(&c);
>>> +	}
>>> +	else if (!strcmp(op, "reject")) {
>>> +		credential_reject(&c);
>>> +	}
>>> +	else
>>> +		usage(usage_msg);
>>
>> Braces for the last "else" part. In general, the structure should be
>>
>>       if (...) {
>>                /*code*/
>>       } else if (...) {
>>                /*code*/
>>       } else {
>>                /*code*/
>>       }
>>
>> If juste one block needs brances, all the other "else if"/"else" part
>> need it too.
>>
>> BTW, please be aware of the white spaces (here mostly in the doc) :).
>>
>> Lucien Kong.
>
> I will remove brances.

The remark was about adding them, not removing them. There's one branch
of the if/else if/ with several instructions, so we usually put braces
everywhere.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/