From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Thu, 13 Jun 2013 11:44:40 GMT
Subject: Re: [PATCH/RFC 1/4] git-mw: Introduction of GitMediawiki.pm
Message-ID: <vpq8v2etetz.fsf@anie.imag.fr>
In-Reply-To: <1371118039-18925-2-git-send-email-benoit.person@ensimag.fr>

benoit.person@ensimag.fr writes:

> +install_pm:
> +	cp $(GIT_MEDIAWIKI_PM) $(INSTLIBDIR)

Better use "install", which is roughly like "cp".

Also, this fails if the target dir does not exist, ie. if one did not
run "make install" at the toplevel Git. It's OK, but perhaps you should
add a comment in the Makefile like '# Run "make install" from Git's
toplevel before using this'.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/