From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Fri, 11 Mar 2016 13:30:28 GMT
Subject: Re: [PATCH v7 2/2] pull --rebase: add --[no-]autostash flag
Message-ID: <vpq8u1p16rv.fsf@anie.imag.fr>
In-Reply-To: <CA+DCAeSvjyy6WO=n-wdo3_yHGSWmUC0Epbt-OYLF_fbuczeeKA@mail.gmail.com>

Mehul Jain <mehul.jain2029@gmail.com> writes:

> On Fri, Mar 11, 2016 at 10:21 AM, Paul Tan <pyokagan@gmail.com> wrote:
>>>  static int config_autostash = -1;
>>
>> Hmm, why can't config_autostash just default to 0?
>
> Previously Junio recommended not to explicitly initialize a
> static to 0 (or NULL).
> http://thread.gmane.org/gmane.comp.version-control.git/287709/focus=287726

What Junio says is that you don't need to write

static int config_autostash = 0;

since it is equivalent to

static int config_autostash;

But there's nothing wrong with having a static variable defaulting to 0.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/