From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Fri, 05 Apr 2013 07:40:21 GMT
Subject: Re: [PATCH v2 3/3] diffcore-pickaxe: respect --no-textconv
Message-ID: <vpq7gkhqvbu.fsf@grenoble-inp.fr>
In-Reply-To: <7d36738417942b594c185953115a244ad6f3c7a0.1365105971.git.simon@ruderich.org>

Simon Ruderich <simon@ruderich.org> writes:

> --- a/t/t4209-log-pickaxe.sh
> +++ b/t/t4209-log-pickaxe.sh
> @@ -116,4 +116,18 @@ test_expect_success 'log -S -i (nomatch)' '
>  	test_cmp expect actual
>  '
>  
> +test_expect_success 'log -S --textconv (missing textconv tool)' '
> +	echo "* diff=test" >.gitattributes &&
> +	test_must_fail git -c diff.test.textconv=missing log -Sfoo &&
> +	rm .gitattributes
> +'
> +
> +test_expect_success 'log -S --no-textconv (missing textconv tool)' '
> +	echo "* diff=test" >.gitattributes &&
> +	git -c diff.test.textconv=missing log -Sfoo --no-textconv >actual &&
> +	>expect &&
> +	test_cmp expect actual &&
> +	rm .gitattributes
> +'

While we're there, we could test -G --no-textconv too.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/