From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Tue, 29 Sep 2009 16:59:17 GMT
Subject: Re: clone from url with email address as username?(escaping @ symbol)
Message-ID: <vpq63b1u1p6.fsf@bauges.imag.fr>
In-Reply-To: <970bc7c80909290831l59b7fc4at4ec0082f42f3ef87@mail.gmail.com>

Ben Bennett <benbennett@gmail.com> writes:

> I am attempting to do a https clone. The username is an email address
> but when I do a clone here is what happens.

Hmm, right, it works with ssh, but not http.

I tried a quick fix like this:

diff --git a/http.c b/http.c
index 23b2a19..361a6be 100644
--- a/http.c
+++ b/http.c
@@ -281,9 +281,10 @@ static void http_auth_init(const char *url)
         * "proto://<host>/..."?
         */
        cp += 3;
-       at = strchr(cp, '@');
        colon = strchr(cp, ':');
        slash = strchrnul(cp, '/');
+       for(at = slash-1; *at != '@' && *at != '/'; at--)
+               continue;
        if (!at || slash <= at)
                return; /* No credentials */
        if (!colon || at <= colon) {

Unfortunately, it seems the complete URL is passed to curl, and curl
is the one doing it wrong. Indeed:

$ curl -v https://user@email.com@server.com/path/                                          
* getaddrinfo(3) failed for email.com@server.com:443
* Couldn't resolve host 'email.com@server.com'
* Closing connection #0
curl: (6) Couldn't resolve host 'email.com@server.com'

Now for the good news:

http://curl.haxx.se/mail/lib-2006-02/0134.html
http://sourceforge.net/tracker/index.php?func=detail&aid=2826621&group_id=976&atid=100976

In short, you have to use %40 to escape the @, and curl does it this
way because the RFC doesn't allow @ in usernames.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/