From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Thu, 04 Jun 2015 08:11:25 GMT
Subject: Re: [PATCH 4/4] status: add new tests for status during rebase -i
Message-ID: <vpq6173zydu.fsf@anie.imag.fr>
In-Reply-To: <1433368825-24617-4-git-send-email-guillaume.pages@ensimag.grenoble-inp.fr>

I'd swap 3/4 and 4/4 so that we see the impact of your code on these new
tests. I won't insist on that though.

Please help reviewers by explaining in the commit message why these
tests are needed (what was not covered properly by existing tests?)

Guillaume Pagès <guillaume.pages@ensimag.grenoble-inp.fr> writes:

> +test_expect_success 'status: two commands done, two remainings' '
> +	FAKE_LINES="1 exec_exit_15 2 3" &&
> +	export FAKE_LINES &&
> +	test_when_finished "git rebase --abort" &&
> +	ONTO=$(git rev-parse --short HEAD~3) &&
> +	COMMIT4=$(git rev-parse HEAD) &&
> +	COMMIT3=$(git rev-parse HEAD^) &&
> +	COMMIT2=$(git rev-parse HEAD^^) &&
> +	(git rebase -i HEAD~3 || true)&&

Space before &&

(same on second test)

> +       cat >expected <<EOF &&

Indent with spaces.

I did not do a thourough review, but this version looks much, much nicer
than the previous one (see how PATCH 1/4 and PATCH 2/4 are nice now?).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/