From: Matthieu Moy Date: Mon, 12 Oct 2015 19:07:35 GMT Subject: Re: [PATCH v2 00/10] port branch.c to use ref-filter's printing options Message-ID: In-Reply-To: Junio C Hamano writes: > If you design a new infrastructure to help refactoring early > (i.e. before adding many copies of code that need to be cleaned up > later), it would make the work of reviewing of the design of the > helper and refactoring using that helper smaller, not larger. But most of the code concerned is already reviewed. The first instances of the pattern to refactor is already in next. With a real time machine, we could go back in past, refactor and then have cleaner series, but with Git as our only tool we can't ;-). The current series will just add one more instance of sub-optimal code, it isn't hard to review. Inserting new code before them would make the interdiff far bigger. -- Matthieu Moy http://www-verimag.imag.fr/~moy/